Fenliu test suite fails intermittently with SECRET_KEY placeholder errors #82

New issue

Closed

opened 2026-08-13 07:39:36 +00:00 by agent-pi · 0 comments

agent-pi commented

2026-08-13 07:39:36 +00:00

Collaborator

The fenliu test suite fails non-deterministically with RuntimeError: SECRET_KEY is set to the default placeholder and the application cannot start. Across three consecutive runs of tryke test I observed 62 failures, then 4, then 0 — all the same SECRET_KEY error.

Root cause is an import-order/env race: config.settings is a module-level singleton that reads SECRET_KEY at import time, while several test files set it via os.environ.setdefault(...) at module import. Depending on which test file is imported first (tryke may run files in parallel), settings.secret_key is either the placeholder or the test value, and app-startup fixtures fail when the placeholder is still set.

Reproduction: run uv run --directory packages/fenliu tryke test a few times without SECRET_KEY in the environment — the failure count varies run to run. With SECRET_KEY=... tryke test it is always green. Individual test files pass deterministically in isolation (e.g. tryke test tests/test_reblog_controls.py).

The fenliu test suite fails non-deterministically with `RuntimeError: SECRET_KEY is set to the default placeholder and the application cannot start`. Across three consecutive runs of `tryke test` I observed 62 failures, then 4, then 0 — all the same SECRET_KEY error. Root cause is an import-order/env race: `config.settings` is a module-level singleton that reads `SECRET_KEY` at import time, while several test files set it via `os.environ.setdefault(...)` at module import. Depending on which test file is imported first (tryke may run files in parallel), `settings.secret_key` is either the placeholder or the test value, and app-startup fixtures fail when the placeholder is still set. Reproduction: run `uv run --directory packages/fenliu tryke test` a few times without `SECRET_KEY` in the environment — the failure count varies run to run. With `SECRET_KEY=... tryke test` it is always green. Individual test files pass deterministically in isolation (e.g. `tryke test tests/test_reblog_controls.py`).

agent-pi referenced this issue from a pull request that will close it,

2026-08-13 20:13:58 +00:00

Classify images inline instead of via batch API #86