Review filters: fix AI filters not applying, tidy layout, reword labels #87

Closed
opened 2026-08-13 20:50:49 +00:00 by agent-pi · 1 comment
Collaborator

Three review-page filter issues found during systems testing:

  1. The AI filters don't apply. Selecting "show only AI-would-reject" (or "hide not-yet-classified") and clicking "Apply filters" still shows posts with "AI: OK" in the list — the filter conditions aren't reaching the query.

  2. Layout. "Filter by stream" renders as a full-length dropdown, with the two AI checkboxes stacked underneath. Make the streams dropdown shorter and put the two checkboxes on the same line beside it.

  3. Wording. The checkbox labels expose the code terms ("show only AI-would-reject", "hide not-yet-classified"). Reword them into human-friendly labels.

Three review-page filter issues found during systems testing: 1. **The AI filters don't apply.** Selecting "show only AI-would-reject" (or "hide not-yet-classified") and clicking "Apply filters" still shows posts with "AI: OK" in the list — the filter conditions aren't reaching the query. 2. **Layout.** "Filter by stream" renders as a full-length dropdown, with the two AI checkboxes stacked underneath. Make the streams dropdown shorter and put the two checkboxes on the same line beside it. 3. **Wording.** The checkbox labels expose the code terms ("show only AI-would-reject", "hide not-yet-classified"). Reword them into human-friendly labels.
Author
Collaborator

Plan of attack:

  • Fix the filter wiring in liveviews.py (ReviewLiveView): the show_ai_reject / hide_unclassified values from the apply-filters action need to become SQLAlchemy conditions on the posts query (Post.ai_would_reject.is_(True) / Post.ai_would_reject.is_not(None)).
  • Rework the filter bar markup in the ReviewLiveView render: shorter streams dropdown, and the two AI checkboxes on the same line beside it.
  • Reword the checkbox labels to human-friendly text.

Branch: feat/issue-87-review-filter-fixes (off feat/issue-80-collect).

Plan of attack: - Fix the filter wiring in `liveviews.py` (`ReviewLiveView`): the `show_ai_reject` / `hide_unclassified` values from the apply-filters action need to become SQLAlchemy conditions on the posts query (`Post.ai_would_reject.is_(True)` / `Post.ai_would_reject.is_not(None)`). - Rework the filter bar markup in the ReviewLiveView render: shorter streams dropdown, and the two AI checkboxes on the same line beside it. - Reword the checkbox labels to human-friendly text. Branch: `feat/issue-87-review-filter-fixes` (off `feat/issue-80-collect`).
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
marvin8/dujiangyan#87
No description provided.