marvin8/dujiangyan
Watch
1
0
Fork
You've already forked dujiangyan
 0
Code Issues 4 Pull requests Projects Releases 48 Wiki Activity Actions

Rename reviewer_notes to auto_reject_reason and drop the duplicate #90

Manually merged
marvin8 merged 1 commit from feat/issue-85-auto-reject-reason into feat/issue-80-collect 2026-08-14 04:06:53 +00:00
Conversation 1 Commits 1 Files changed 16 +82 -67
agent-pi commented 2026-08-14 03:27:30 +00:00
Collaborator
Copy link

posts.reviewer_notes was written only by reject_blocked_posts (as [auto-rejected] {reason}), and review_feedback.reviewer_notes was a never-read duplicate. This renames the post field to auto_reject_reason, drops the feedback column, and removes the vestigial reviewer_notes field from the PATCH /posts/{id} request body.

Changes:

  • Post.reviewer_notes → Post.auto_reject_reason (its only writer is auto-reject).
  • Drop ReviewFeedback.reviewer_notes.
  • PostUpdate loses reviewer_notes; PostResponse exposes auto_reject_reason.
  • create_review_feedback loses its reviewer_notes parameter.
  • One alembic migration (rename + drop column); tests and docs updated.

Refs #85

`posts.reviewer_notes` was written only by `reject_blocked_posts` (as `[auto-rejected] {reason}`), and `review_feedback.reviewer_notes` was a never-read duplicate. This renames the post field to `auto_reject_reason`, drops the feedback column, and removes the vestigial `reviewer_notes` field from the `PATCH /posts/{id}` request body. Changes: - `Post.reviewer_notes` → `Post.auto_reject_reason` (its only writer is auto-reject). - Drop `ReviewFeedback.reviewer_notes`. - `PostUpdate` loses `reviewer_notes`; `PostResponse` exposes `auto_reject_reason`. - `create_review_feedback` loses its `reviewer_notes` parameter. - One alembic migration (rename + drop column); tests and docs updated. Refs #85
♻️ rename reviewer_notes to auto_reject_reason and drop duplicate
All checks were successful
/ gitleaks (pull_request) Successful in 16s
Details
/ pr-review (pull_request) Successful in 34s
Details
/ checks (pull_request) Successful in 2m15s
Details
/ publish (pull_request) Has been skipped
Details
/ publish-container (pull_request) Has been skipped
Details
/ deploy-docs (pull_request) Has been skipped
Details
8ab5cc82ef
 
posts.reviewer_notes was written only by reject_blocked_posts, and
review_feedback.reviewer_notes was a never-read duplicate. Rename the
post field to auto_reject_reason, drop the feedback column, remove the
vestigial PATCH input field, and update the migration, tests, and docs.
marvin8 approved these changes 2026-08-14 04:06:23 +00:00
marvin8 manually merged commit ac71032a9b into feat/issue-80-collect 2026-08-14 04:06:53 +00:00
marvin8 deleted branch feat/issue-85-auto-reject-reason 2026-08-14 04:08:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
marvin8
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
marvin8/dujiangyan!90
No description provided.