CLI: validate parent_dir and base_url with actionable errors #26

New issue

Closed

opened 2026-08-19 20:37:51 +00:00 by agent-pi · 1 comment

agent-pi commented

2026-08-19 20:37:51 +00:00

Collaborator

sub2pod does not validate its two key CLI inputs before use.

parent_dir: passing a path that does not exist or is not a directory surfaces as a cryptic NotADirectoryError deep inside the directory walk, with no guidance about what went wrong.
base_url: a malformed value (no scheme, wrong scheme, or garbage) is accepted silently and produces broken <enclosure> links in the generated feed, which the user only notices later in their podcast client.

sub2pod does not validate its two key CLI inputs before use. - `parent_dir`: passing a path that does not exist or is not a directory surfaces as a cryptic `NotADirectoryError` deep inside the directory walk, with no guidance about what went wrong. - `base_url`: a malformed value (no scheme, wrong scheme, or garbage) is accepted silently and produces broken `<enclosure>` links in the generated feed, which the user only notices later in their podcast client.

agent-pi commented

2026-08-19 20:38:14 +00:00

Author

Collaborator

Plan of attack:

Add failing tests first (Tryke) in tests/test_cli.py:
- missing parent_dir → clear, actionable error
- parent_dir is a file, not a directory → clear error
- base_url without http:///https:// scheme → clear error
Validate both inputs early in src/sub2pod/cli.py and raise/print actionable messages instead of letting the failure surface mid-walk.
Run uv run tryke test until green.

Decision taken (flag if you disagree): base_url is validated to require an http:// or https:// scheme. Relative-URL support is out of scope unless you want it — that was the fork in the improvements.md task.

Plan of attack: 1. Add failing tests first (Tryke) in `tests/test_cli.py`: - missing `parent_dir` → clear, actionable error - `parent_dir` is a file, not a directory → clear error - `base_url` without `http://`/`https://` scheme → clear error 2. Validate both inputs early in `src/sub2pod/cli.py` and raise/print actionable messages instead of letting the failure surface mid-walk. 3. Run `uv run tryke test` until green. Decision taken (flag if you disagree): `base_url` is validated to require an `http://` or `https://` scheme. Relative-URL support is out of scope unless you want it — that was the fork in the improvements.md task.

agent-pi referenced this issue from a pull request that will close it,

2026-08-19 20:46:13 +00:00

Validate parent_dir and base_url with actionable errors #33

agent-pi referenced this issue

2026-08-19 20:51:20 +00:00

Validate parent_dir and base_url with actionable errors #33

agent-pi closed this issue

2026-08-20 10:10:06 +00:00