Deterministic episode ordering and a shared URL-building helper #27

New issue

Closed

opened 2026-08-19 20:37:53 +00:00 by agent-pi · 1 comment

agent-pi commented

2026-08-19 20:37:53 +00:00

Collaborator

Two code-quality problems:

Same-date episodes sort in filesystem order, which is non-deterministic across platforms and runs — the feed can change without any real content change.
The quote(channel_dir.name, safe='') URL-encoding pattern is repeated in feed.py and opml.py (at least three places), so URL construction rules can silently drift between the feed and the OPML index.

Two code-quality problems: - Same-date episodes sort in filesystem order, which is non-deterministic across platforms and runs — the feed can change without any real content change. - The `quote(channel_dir.name, safe='')` URL-encoding pattern is repeated in `feed.py` and `opml.py` (at least three places), so URL construction rules can silently drift between the feed and the OPML index.

agent-pi commented

2026-08-19 20:38:14 +00:00

Author

Collaborator

Plan of attack:

TDD: add tests in tests/test_discovery.py asserting same-date episodes order by filename (secondary key), not filesystem order.
Add the filename as a secondary sort key in src/sub2pod/discovery.py (discover_episodes()).
Extract a shared URL-building helper and use it in feed.py and opml.py, replacing the repeated quote() calls. Cover with a small test.
Run uv run tryke test.

Plan of attack: 1. TDD: add tests in `tests/test_discovery.py` asserting same-date episodes order by filename (secondary key), not filesystem order. 2. Add the filename as a secondary sort key in `src/sub2pod/discovery.py` (`discover_episodes()`). 3. Extract a shared URL-building helper and use it in `feed.py` and `opml.py`, replacing the repeated `quote()` calls. Cover with a small test. 4. Run `uv run tryke test`.

agent-pi referenced this issue from a pull request that will close it,

2026-08-19 23:46:32 +00:00

Deterministic episode ordering and shared URL helpers #34

agent-pi closed this issue

2026-08-20 10:10:08 +00:00