PR review runs outdated WuMing and reports low-severity findings #18

New issue

Closed

opened 2026-10-16 23:32:32 +00:00 by agent-pi · 1 comment

agent-pi commented

2026-10-16 23:32:32 +00:00

Collaborator

The pr-review CI job still pins WuMing 0.11.0, and it posts inline review comments at every severity level — including low-severity nits that drown out the findings worth acting on.

Two things wanted:

Track the current WuMing release (0.12.0).
Raise the floor so only medium-and-above findings are posted.

The `pr-review` CI job still pins WuMing 0.11.0, and it posts inline review comments at every severity level — including low-severity nits that drown out the findings worth acting on. Two things wanted: - Track the current WuMing release (0.12.0). - Raise the floor so only medium-and-above findings are posted.

agent-pi commented

2026-10-16 23:32:32 +00:00

Author

Collaborator

Findings from exploration:

.forgejo/workflows/ci.yml pins https://forge.marvin8.zone/marvin8/wuming@0.11.0 in the pr-review job; no other file references the wuming version.
WUMING_MIN_SEVERITY (valid values: low, medium, high, critical; fail-closed on anything else) exists since 0.11.0 and is still env-only in 0.12.0 — I verified the action.yml at ref 0.12.0 via the forge API and it defines no min_severity input. So it must be set in a step-level env: block alongside the with: inputs.

Plan of attack:

Bump the pr-review step uses: ref from @0.11.0 to @0.12.0.
Add env: WUMING_MIN_SEVERITY: medium to that same step.

Branch: chore/issue-18-wuming-0.12.0-medium-floor

Commits:

:construction_worker: ci: bump wuming to 0.12.0 and floor findings at medium severity

PR: opened via Forgejo API (POST /repos/marvin8/xique/pulls, head chore/issue-18-wuming-0.12.0-medium-floor, base main, Closes #18).

Findings from exploration: - `.forgejo/workflows/ci.yml` pins `https://forge.marvin8.zone/marvin8/wuming@0.11.0` in the `pr-review` job; no other file references the wuming version. - `WUMING_MIN_SEVERITY` (valid values: `low`, `medium`, `high`, `critical`; fail-closed on anything else) exists since 0.11.0 and is still **env-only** in 0.12.0 — I verified the `action.yml` at ref `0.12.0` via the forge API and it defines no `min_severity` input. So it must be set in a step-level `env:` block alongside the `with:` inputs. Plan of attack: 1. Bump the `pr-review` step `uses:` ref from `@0.11.0` to `@0.12.0`. 2. Add `env: WUMING_MIN_SEVERITY: medium` to that same step. Branch: `chore/issue-18-wuming-0.12.0-medium-floor` Commits: - `:construction_worker: ci: bump wuming to 0.12.0 and floor findings at medium severity` PR: opened via Forgejo API (`POST /repos/marvin8/xique/pulls`, head `chore/issue-18-wuming-0.12.0-medium-floor`, base `main`, `Closes #18`).

agent-pi referenced this issue from a pull request that will close it,

2026-10-16 23:33:00 +00:00

Bump WuMing to 0.12.0 and floor review findings at medium severity #19

agent-pi closed this issue

2026-10-17 00:11:03 +00:00