publish-container fails on every push to main #34
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Reference
marvin8/xique#34
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Every push to
mainruns thepublish-containerjob, which builds the container withVERSIONtaken fromgithub.ref_name. On a push that value ismain, so the Containerfile runsuv version --no-sync mainand fails with "expected version to start with a number". The job only works onreleaseevents, where the ref is the tag (e.g.0.1.0).Net effect: every push to main shows a red run even when the release pipeline is fully green — seen on runs 1074, 1077, 1086, and 1091 (the 0.1.0 release push; its release-event run 1092 passed and published the image).
Wanted:
publish-containershould not run (or should degrade gracefully) when the event is not a release.Spec: n/a — CI hygiene.
Plan of attack:
publish-containerjob to release events withif: github.event_name == 'release'(the same condition stylepr-reviewalready uses). On pushes the job shows as skipped, so main goes green; on releases nothing changes — the job still builds and publishes from the tag ref, as verified by run 1092.containerbuild-and-smoke-test job stays enabled on both events: it succeeded on the push run, so it keeps providing pre-release image validation.Branch:
fix/issue-34-publish-container-release-onlyCommits:
:bug: ci: run publish-container only on release eventsPR:
POST /repos/marvin8/xique/pulls(headfix/issue-34-publish-container-release-only, basemain,Closes #34).