Hide-read choice resets between visits #49
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Reference
marvin8/yunjin#49
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The hide-read toggle on the reader currently works by adding
?hide_read=1to URLs. The choice is lost as soon as you follow a link that does not carry the parameter, and it never survives closing the browser.The preference should stick across navigation and across visits until it is toggled back off — a cookie is the natural fit for a server-rendered, JavaScript-free UI.
Plan of attack
hide_readquery parameter entirely with ahide_readcookie read by the reader index and aggregate routes — no more threading the parameter through card links, form actions and redirects.POST /reader/hide-readtoggle endpoint: flips the cookie (1 year max-age, HttpOnly, SameSite=Lax), redirects back to a validatednextpath (same-origin, no open redirect). Plain HTML form, no JavaScript.Lands together with #48, #50 and #41 on the shared branch
feat/reader-tweaks-and-docs(one PR).Closed: merged via PR #51.