marvin8/zaojun
Watch
1
0
Fork
You've already forked zaojun
 0
Code Issues 1 Pull requests Releases 46 Activity Actions

Complete stage-2 migration cleanup for zaojun #38

Manually merged
marvin8 merged 5 commits from feat/issue-37-complete-stage2-migration into main 2026-08-18 07:56:26 +00:00
Conversation 5 Commits 5 Files changed 11 +371 -568
agent-pi commented 2026-08-18 06:52:41 +00:00
Collaborator
Copy link

Stage-2 migration cleanup for zaojun.

  • Updated remaining Codeberg references to forge.marvin8.zone / Forgejo:
    • mkdocs.yml copyright link now points to marvin8/taibai on forge
    • ROADMAP-detail.md, docs/development/contributing.md, docs/reference/changelog.md
    • Left as-is (intentional): git-pages/action upload step, CHANGELOG.md history, docs/javascripts/redirect.js
  • Reset Release-Notes.md to the clean template (1.7.3 already released).
  • Bumped dependencies via zaojun and aligned pre-commit hook revs.
  • pysentry: 0 vulnerabilities.
  • Full nox suite green (12 sessions).

Closes #37

Stage-2 migration cleanup for zaojun. - Updated remaining Codeberg references to forge.marvin8.zone / Forgejo: - `mkdocs.yml` copyright link now points to `marvin8/taibai` on forge - `ROADMAP-detail.md`, `docs/development/contributing.md`, `docs/reference/changelog.md` - Left as-is (intentional): `git-pages/action` upload step, `CHANGELOG.md` history, `docs/javascripts/redirect.js` - Reset `Release-Notes.md` to the clean template (1.7.3 already released). - Bumped dependencies via zaojun and aligned pre-commit hook revs. - pysentry: 0 vulnerabilities. - Full nox suite green (12 sessions). Closes #37
🔧 update remaining Codeberg references to forge.marvin8.zone
All checks were successful
/ gitleaks (pull_request) Successful in 15s
Details
/ checks (pull_request) Successful in 2m13s
Details
/ publish (pull_request) Has been skipped
Details
/ deploy-docs (pull_request) Has been skipped
Details
/ pr-review (pull_request) Successful in 2m52s
Details
d6df5d35e5
🔧 fix copyright to reference zaojun and start at 2024
All checks were successful
/ gitleaks (pull_request) Successful in 20s
Details
/ pr-review (pull_request) Successful in 2m24s
Details
/ checks (pull_request) Successful in 2m24s
Details
/ publish (pull_request) Has been skipped
Details
/ deploy-docs (pull_request) Has been skipped
Details
ec231c25be
forgejo-actions reviewed 2026-08-18 07:34:58 +00:00
forgejo-actions left a comment
Copy link

WuMing

Found 4 issue(s). See inline comments below.

## WuMing Found **4** issue(s). See inline comments below.
.pre-commit-config.yaml
@ -12,3 +12,3 @@
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.16.1
rev: v0.16.2
forgejo-actions commented 2026-08-18 07:34:58 +00:00
Copy link

security [LOW]

A08: Pre-commit hook revision is a mutable Git tag rather than a full commit SHA. A moved or compromised upstream tag could execute untrusted code in CI/developer environments. Pin rev to a full commit SHA.

**security** [LOW] A08: Pre-commit hook revision is a mutable Git tag rather than a full commit SHA. A moved or compromised upstream tag could execute untrusted code in CI/developer environments. Pin rev to a full commit SHA. <!-- wuming:sha256:239d1c20aa74d63c49c54b8981e0dfe70d42c3e0c118c57d58582c4791666149 -->
marvin8 marked this conversation as resolved
.pre-commit-config.yaml
@ -22,3 +22,3 @@
- repo: https://github.com/astral-sh/ty-pre-commit
rev: v0.0.65
rev: v0.0.70
forgejo-actions commented 2026-08-18 07:34:58 +00:00
Copy link

security [LOW]

A08: Pre-commit hook revision is a mutable Git tag rather than a full commit SHA. Pin rev to a full commit SHA to ensure integrity.

**security** [LOW] A08: Pre-commit hook revision is a mutable Git tag rather than a full commit SHA. Pin rev to a full commit SHA to ensure integrity. <!-- wuming:sha256:4f51ee09d2137f475da39e11c10fcd77ed3723498417335f932172078809954b -->
marvin8 marked this conversation as resolved
.pre-commit-config.yaml
@ -27,3 +27,3 @@
- repo: https://github.com/astral-sh/uv-pre-commit
rev: 0.12.2
rev: 0.12.3
forgejo-actions commented 2026-08-18 07:34:58 +00:00
Copy link

security [LOW]

A08: Pre-commit hook revision is a mutable Git tag rather than a full commit SHA. Pin rev to a full commit SHA to ensure integrity.

**security** [LOW] A08: Pre-commit hook revision is a mutable Git tag rather than a full commit SHA. Pin rev to a full commit SHA to ensure integrity. <!-- wuming:sha256:07ed7e74453536816b0a1ef346b6dd129d88c074722eb41894e2bb87425b9ec2 -->
marvin8 marked this conversation as resolved
.pre-commit-config.yaml
@ -39,3 +39,3 @@
- repo: https://github.com/rohaquinlop/complexipy-pre-commit
rev: v5.1.0
rev: v7.0.0
forgejo-actions commented 2026-08-18 07:34:58 +00:00
Copy link

security [LOW]

A08: Pre-commit hook revision is a mutable Git tag rather than a full commit SHA. Pin rev to a full commit SHA to ensure integrity.

**security** [LOW] A08: Pre-commit hook revision is a mutable Git tag rather than a full commit SHA. Pin rev to a full commit SHA to ensure integrity. <!-- wuming:sha256:0126e7b4dfd1f2f2352f9e021c18923d0212572397b36ee49d955877c66fe035 -->
marvin8 marked this conversation as resolved
agent-pi commented 2026-08-18 07:39:47 +00:00
Author
Collaborator
Copy link

🔴 Not actioned — pre-commit rev: stays on version tags

.pre-commit-config.yaml line 14 · .pre-commit-config.yaml line 24 · .pre-commit-config.yaml line 29 · .pre-commit-config.yaml line 41

Pre-commit hook revision is a mutable Git tag rather than a full commit SHA…

Keeping rev: pinned to version tags is the project's documented convention. The "Pre-commit hook version alignment" rule in AGENTS.md sets rev: to the version number (e.g. v0.16.2), and every hook in this file uses the same tag style. The LOW supply-chain risk is accepted in favour of readable, version-aligned revs.

### 🔴 Not actioned — pre-commit `rev:` stays on version tags [`.pre-commit-config.yaml` line 14](https://forge.marvin8.zone/marvin8/zaojun/pulls/38#issuecomment-1580) · [`.pre-commit-config.yaml` line 24](https://forge.marvin8.zone/marvin8/zaojun/pulls/38#issuecomment-1581) · [`.pre-commit-config.yaml` line 29](https://forge.marvin8.zone/marvin8/zaojun/pulls/38#issuecomment-1582) · [`.pre-commit-config.yaml` line 41](https://forge.marvin8.zone/marvin8/zaojun/pulls/38#issuecomment-1583) > Pre-commit hook revision is a mutable Git tag rather than a full commit SHA… Keeping `rev:` pinned to version tags is the project's documented convention. The "Pre-commit hook version alignment" rule in AGENTS.md sets `rev:` to the version number (e.g. `v0.16.2`), and every hook in this file uses the same tag style. The LOW supply-chain risk is accepted in favour of readable, version-aligned revs.
marvin8 approved these changes 2026-08-18 07:45:12 +00:00
Dismissed
🔧 make zaojun in noxfile be a little more forgivin
All checks were successful
/ gitleaks (pull_request) Successful in 16s
Details
/ checks (pull_request) Successful in 2m25s
Details
/ publish (pull_request) Has been skipped
Details
/ deploy-docs (pull_request) Has been skipped
Details
/ pr-review (pull_request) Successful in 2m31s
Details
ff2248e96e
 
Signed-off-by: Marvin8 <marvin8@tuta.io>
agent-pi dismissed marvin8's review 2026-08-18 07:46:56 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

forgejo-actions reviewed 2026-08-18 07:49:28 +00:00
forgejo-actions left a comment
Copy link

WuMing

Found 1 issue(s). See inline comments below.

## WuMing Found **1** issue(s). See inline comments below.
noxfile.py
@ -93,3 +93,3 @@
def dependency_versions(session):
session.install(".")
session.run("zaojun", "--compat-ok")
session.run("zaojun", "--compat-ok", "--no-groups")
forgejo-actions commented 2026-08-18 07:49:28 +00:00
Copy link

code [MEDIUM]

Adding --no-groups makes zaojun skip dependency groups. The dependency_versions session is intended to verify dependency versions, so this change reduces coverage and can hide incompatibilities in optional/group dependencies. Either install the relevant groups in the session or confirm this is intentional and document why group checks are disabled.

**code** [MEDIUM] Adding `--no-groups` makes `zaojun` skip dependency groups. The `dependency_versions` session is intended to verify dependency versions, so this change reduces coverage and can hide incompatibilities in optional/group dependencies. Either install the relevant groups in the session or confirm this is intentional and document why group checks are disabled. <!-- wuming:sha256:7faf2081e5313db22448991f6d1eebc417b4112a54716a9905879385fbae6afe -->
marvin8 marked this conversation as resolved
marvin8 approved these changes 2026-08-18 07:55:46 +00:00
marvin8 manually merged commit 40cae2cbc4 into main 2026-08-18 07:56:26 +00:00
marvin8 deleted branch feat/issue-37-complete-stage2-migration 2026-08-18 07:57:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
marvin8
Labels
Clear labels   
bug
Something is not working

  
contribution welcome
Contributions are very welcome, get started here

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
good first issue
Interested in contributing? Get started here.

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
upstream
Related to an upstream repository, already reported there

No labels
bug
contribution welcome
duplicate
enhancement
good first issue
help wanted
invalid
question
upstream
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
marvin8/zaojun!38
No description provided.