marvin8/feed2fedi
Watch
1
0
Fork
You've already forked feed2fedi
 0
Code Issues 1 Pull requests Releases 51 Activity Actions

reorder entries in feed by published field #11

Closed
MrClon wants to merge 0 commits from refs/pull/11/head into wip
pull from: refs/pull/11/head
merge into: marvin8:wip
Conversation 5 Commits - Files changed 1 +5
MrClon commented 2023-11-28 22:12:42 +00:00 (Migrated from codeberg.org)
Copy link

Entries in feed can be ordered in any way. If they ordered not from older to newer, and there is more then one new entry in feed, new entries will be posted in wrong order. This patch fix it

Entries in feed can be ordered in any way. If they ordered not from older to newer, and there is more then one new entry in feed, new entries will be posted in wrong order. This patch fix it
marvin8 commented 2023-11-29 00:38:29 +00:00 (Migrated from codeberg.org)
Copy link

Not sure this is a clear cut as this. Some users might want to publish in chronological order starting with oldest to newest and some other users might want to publish in inverse chronical order.

What's your thoughts on this?

Not sure this is a clear cut as this. Some users might want to publish in chronological order starting with oldest to newest and some other users might want to publish in inverse chronical order. What's your thoughts on this?
marvin8 commented 2023-11-29 00:39:14 +00:00 (Migrated from codeberg.org)
Copy link

Sorry accidentally closed this pr... reopening now... bugger... won't let me.

Sorry accidentally closed this pr... reopening now... bugger... won't let me.
MrClon commented 2023-11-29 08:21:23 +00:00 (Migrated from codeberg.org)
Copy link

If feed ordered from new-to-old then posts if fedi will be in mixed order. After first run there will be several posts in reverse order. But next posts will be in chronological order unless there was more then one entries added to feed between feed2fedi runs (they will be in reverse order). It will be something like this:

08 \
09  | suddenly 3 posts was added between runs
10 /
07 -> one new post per run
06 -> one new post per run
01 \
02  |
03  | initial chunk
04  |
05 /
If feed ordered from new-to-old then posts if fedi will be in mixed order. After first run there will be several posts in reverse order. But next posts will be in chronological order unless there was more then one entries added to feed between feed2fedi runs (they will be in reverse order). It will be something like this: ``` 08 \ 09 | suddenly 3 posts was added between runs 10 / 07 -> one new post per run 06 -> one new post per run 01 \ 02 | 03 | initial chunk 04 | 05 / ```
MrClon commented 2023-11-29 08:36:13 +00:00 (Migrated from codeberg.org)
Copy link

Can't reopen PR. Maybe you just commit it by yourself?

Can't reopen PR. Maybe you just commit it by yourself?
marvin8 commented 2023-11-30 04:07:10 +00:00 (Migrated from codeberg.org)
Copy link

Yeah... I think you are right. I have implemented your changes. Thanks

Yeah... I think you are right. I have implemented your changes. Thanks

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something is not working

  
contribution welcome
Contributions are very welcome, get started here

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
good first issue
Interested in contributing? Get started here.

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
upstream
Related to an upstream repository, already reported there

No labels
bug
contribution welcome
duplicate
enhancement
good first issue
help wanted
invalid
question
upstream
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
marvin8/feed2fedi!11
No description provided.