Migrate project URLs and CI from Codeberg to forge.marvin8.zone #17
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/issue-16-migrate-to-forge"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #16
Summary
Migrate all project references, CI, and remotes from Codeberg to forge.marvin8.zone.
Changes
Notes
clauderemote retained until migration confirmed workingWuMing
Found 1 issue(s). See inline comments below.
@ -92,3 +92,3 @@git config user.email "ci@forgejo"git config user.name "Forgejo Actions"git remote set-url origin https://x-token-auth:$FORGEJO_TOKEN@codeberg.org/${{ github.repository }}.gitgit remote set-url origin https://x-token-auth:$FORGEJO_TOKEN@forge.marvin8.zone/${{ github.repository }}.gitsecurity [MEDIUM]
The Git remote URL includes a secret token in the command line, which could be visible in CI logs if shell tracing or verbose output is enabled. Use a credential helper or
extraheaderapproach that doesn't place the token directly in the command. (A02, A05).forgejo/workflows/ci.ymlline 0✅ Fixed in commit
6bc0947— replacedgit remote set-urlwithgit config --local http.extraHeader..forgejo/workflows/ci.ymlline 0🔴 Reverted in commit
1e630a9— the extraheader format was untested and would likely break docs publishing. The token-in-URL pattern is pre-existing, working, and thedeploy-docsjob only runs on tag pushes (not PRs), so it was never verified. Better to keep the known-working pattern.WuMing
Found 1 issue(s). See inline comments below.
@ -13,3 +13,3 @@if: github.event_name == 'pull_request'steps:- uses: https://codeberg.org/marvin8/wuming@main- uses: https://forge.marvin8.zone/marvin8/wuming@mainsecurity [MEDIUM]
External GitHub Action fetched from a private domain (forge.marvin8.zone) without integrity verification (no pinned commit SHA or checksum). An attacker who controls this action could compromise the CI/CD pipeline and access secrets. Use a trusted source or pin to a specific commit hash. (A08: Software and Data Integrity Failures).
WuMing
Found 1 issue(s). See inline comments below.
@ -606,6 +606,7 @@ class StatsPanel(Widget):period_total: float,daily_average: float,streak: tuple[str, int],*,tests [LOW]
Source file modified (function signature made keyword-only) without any corresponding test changes in the diff. Add or update tests that verify the updated call signature and behavior, especially coverage for callers relying on positional optional arguments.
.forgejo/workflows/ci.ymlline 0🔴 Not actioned — the
@mainpattern is pre-existing (only the domain changed from codeberg.org in this PR). forge.marvin8.zone is your own instance, not an untrusted external source. Pinning commit SHAs across all actions is a separate concern.src/rainlog/tui.pyline 0🔴 Not actioned — all callers in both
src/rainlog/tui.pyandtests/test_tui_helpers.pyalready pass arguments by keyword. The*separator makes the existing convention mandatory but changes no behavior and requires no test updates.