Self-review posts LOW nit findings; no severity floor configured #105

New issue

Closed

opened 2026-10-16 22:26:35 +00:00 by agent-pi · 1 comment

agent-pi commented

2026-10-16 22:26:35 +00:00

Collaborator

Our own PR-review workflow (.forgejo/workflows/ci.yml, pr-review job) runs WuMing without a severity floor, so LOW wording/style nits post on every review wave and every fix-push re-raising them. On #75 the maintainer declined most LOW findings and several MEDIUM ones.

WuMing 0.12.0 (already what self-review runs, via uses: ./) supports a severity floor and findings fact-checking; the self-review config predates both.

Our own PR-review workflow (`.forgejo/workflows/ci.yml`, `pr-review` job) runs WuMing without a severity floor, so LOW wording/style nits post on every review wave and every fix-push re-raising them. On #75 the maintainer declined most LOW findings and several MEDIUM ones. WuMing 0.12.0 (already what self-review runs, via `uses: ./`) supports a severity floor and findings fact-checking; the self-review config predates both.

agent-pi commented

2026-10-16 22:26:51 +00:00

Author

Collaborator

Findings from exploration:

The pr-review job uses uses: ./ — it reviews every PR with the PR's own checkout, so 0.12.0 features (verification pass, severity floor) are already available; there is no version ref to bump. Pinning @0.12.0 would replace dogfooding with released-code review — a semantic change, not an update, so not done here.
min_severity has no with: input in action.yml (env-only option), so the floor is configured via a step-level env: block.
Verification (WUMING_VERIFY) defaults to on, so no explicit config needed.

Plan of attack:

.forgejo/workflows/ci.yml, pr-review step: add env: WUMING_MIN_SEVERITY: "medium".
Level medium is the recommendation: on #75 most LOW findings were declined, and the MEDIUM ones that were declined were false-premise class — which the 0.11.0 verification pass now catches before posting, so surviving MEDIUMs are worth seeing. Raising later is one env var; recovering dropped findings is not possible.

Branch: feat/issue-105-ci-severity-floor
Commit: :construction_worker: enable medium severity floor for self-review
PR: targets main, Closes #105

**Findings from exploration:** - The `pr-review` job uses `uses: ./` — it reviews every PR with the PR's own checkout, so 0.12.0 features (verification pass, severity floor) are already available; there is no version ref to bump. Pinning `@0.12.0` would replace dogfooding with released-code review — a semantic change, not an update, so not done here. - `min_severity` has no `with:` input in `action.yml` (env-only option), so the floor is configured via a step-level `env:` block. - Verification (`WUMING_VERIFY`) defaults to on, so no explicit config needed. **Plan of attack:** 1. `.forgejo/workflows/ci.yml`, `pr-review` step: add `env: WUMING_MIN_SEVERITY: "medium"`. 2. Level **medium** is the recommendation: on #75 most LOW findings were declined, and the MEDIUM ones that were declined were false-premise class — which the 0.11.0 verification pass now catches before posting, so surviving MEDIUMs are worth seeing. Raising later is one env var; recovering dropped findings is not possible. **Branch:** `feat/issue-105-ci-severity-floor` **Commit:** `:construction_worker: enable medium severity floor for self-review` **PR:** targets `main`, `Closes #105`

agent-pi referenced this issue from a pull request that will close it,

2026-10-16 22:27:27 +00:00

Enable medium severity floor for self-review #106

agent-pi closed this issue

2026-10-16 22:40:08 +00:00