Skip unchanged files on re-review #85

New issue

Closed

opened 2026-10-15 19:45:42 +00:00 by agent-pi · 1 comment

agent-pi commented

2026-10-15 19:45:42 +00:00

Collaborator

Re-reviews re-examine files that were already reviewed and were not modified by the fix-push, costing tokens and generating repeat findings for code that has not changed.

Review caching — skipping (or downweighting) files whose reviewed content is byte-identical since the previous wave — would make each wave focus only on what the fix actually touched.

Re-reviews re-examine files that were already reviewed and were not modified by the fix-push, costing tokens and generating repeat findings for code that has not changed. Review caching — skipping (or downweighting) files whose reviewed content is byte-identical since the previous wave — would make each wave focus only on what the fix actually touched.

agent-pi added this to the Review quality & convergence milestone

2026-10-15 19:45:42 +00:00

agent-pi added the

Kind/Enhancement

Priority

Low

labels

2026-10-15 19:45:42 +00:00

agent-pi referenced this issue

2026-10-16 23:38:44 +00:00

action.yml missing wave-1 inputs (verify, min_severity) #107

agent-pi referenced this issue

2026-10-16 23:39:09 +00:00

Conversational re-reviews: feed the previous review thread back #79

agent-pi commented

2026-10-16 23:39:10 +00:00

Author

Collaborator

Wave 2 plan (after #79). Explored: Forgejo review objects carry commit_id, so "what changed since the last WuMing wave" is computable without any stored state.

Plan of attack

Branch: feat/issue-85-skip-unchanged (stacks after #79 merges; reuses its structured list_reviews())
When a prior WuMing review exists at commit_id X: fetch the compare X…head changed-file set; files present in the current diff but absent from that set are skipped before routing (first wave on a PR still reviews everything)
Skipped files logged (DEBUG per file, INFO summary count) so WUMING_VERBOSE shows what was excluded
Config: WUMING_SKIP_UNCHANGED (default on; false forces a full re-review) — action.yml input in the same PR
Docs: README, CLAUDE.md, Release-Notes.md; tests via tryke (changed-set computation, first-wave passthrough, disable switch)

Refs the wave plan on #79.

Wave 2 plan (after #79). Explored: Forgejo review objects carry `commit_id`, so "what changed since the last WuMing wave" is computable without any stored state. **Plan of attack** - Branch: `feat/issue-85-skip-unchanged` (stacks after #79 merges; reuses its structured `list_reviews()`) - When a prior WuMing review exists at `commit_id` X: fetch the compare X…head changed-file set; files present in the current diff but absent from that set are skipped before routing (first wave on a PR still reviews everything) - Skipped files logged (DEBUG per file, INFO summary count) so `WUMING_VERBOSE` shows what was excluded - Config: `WUMING_SKIP_UNCHANGED` (default on; `false` forces a full re-review) — action.yml input in the same PR - Docs: README, CLAUDE.md, Release-Notes.md; tests via tryke (changed-set computation, first-wave passthrough, disable switch) Refs the wave plan on #79.

agent-pi referenced this issue

2026-10-16 23:40:57 +00:00

Add verify and min_severity inputs to action.yml #108

agent-pi referenced this issue

2026-10-17 01:11:56 +00:00

Feed the previous review thread back into re-reviews #109

agent-pi referenced this issue from a pull request that will close it,

2026-10-17 01:59:00 +00:00

Skip unchanged files on re-reviews #110

agent-pi closed this issue

2026-10-17 02:15:36 +00:00

agent-pi referenced this issue