Post-migration cleanup: update references to forge.marvin8.zone #56
Loading…
Reference in a new issue
No description provided.
Delete branch "chore/issue-55-migration-cleanup"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #55
WuMing
Found 1 issue(s). See inline comments below.
@ -83,3 +83,3 @@git config user.email "ci@forgejo"git config user.name "Forgejo Actions"git remote set-url origin https://x-token-auth:$FORGEJO_TOKEN@codeberg.org/${{ github.repository }}.gitgit remote set-url origin https://x-token-auth:$FORGEJO_TOKEN@forge.marvin8.zone/${{ github.repository }}.gitsecurity [HIGH]
The Git remote URL embeds the secret token $FORGEJO_TOKEN directly in the URL, which can be exposed in process listings, logs, or shell history. Use a credential helper or pass the token via stdin to avoid leaking the secret. (A02: Cryptographic Failures / A05: Security Misconfiguration)
src/wuming/config.pyline 172🔴 Not actioned — this is an intentional migration. The repo has moved to forge.marvin8.zone and the default reflects the project\u0027s home instance.
WuMing
Found 3 issue(s). See inline comments below.
@ -83,3 +85,3 @@git config user.email "ci@forgejo"git config user.name "Forgejo Actions"git remote set-url origin https://x-token-auth:$FORGEJO_TOKEN@codeberg.org/${{ github.repository }}.gitgit remote set-url origin https://x-token-auth:$FORGEJO_TOKEN@forge.marvin8.zone/${{ github.repository }}.gitsecurity [HIGH]
A02: Passing the FORGEJO_TOKEN directly in a URL via command-line argument risks exposing the secret in CI logs, process listings, or shell history. Use an alternative authentication mechanism (e.g., environment variable injection via git credential helper) to avoid command-line exposure.
@ -109,0 +118,4 @@- name: Install buildahrun: apt-get update -qq && apt-get install -y -qq podman buildah- name: Login to registryrun: buildah login --username "${{ secrets.registry_user }}" --password "${{ secrets.registry_password }}" registry.marvin8.zonesecurity [HIGH]
A02: Passing registry password as a command-line argument exposes it in logs and process tables. Use '--password-stdin' or a credentials file to avoid secret leakage.
@ -170,2 +170,3 @@commit_sha=os.environ.get("CI_COMMIT_SHA", ""),forgejo_url=os.environ.get("WUMING_FORGEJO_URL", "https://codeberg.org"),forgejo_url=os.environ.get("WUMING_FORGEJO_URL", "https://forge.marvin8.zone"code [LOW]
Default Forgejo URL changed from Codeberg to a custom instance (forge.marvin8.zone). This may cause confusion or breakage for users who do not have access to this instance. If the library is meant for public use, consider keeping a generic default or requiring explicit configuration.
src/wuming/config.pyline 172🔴 Not actioned — this is an intentional migration. The repo has moved to forge.marvin8.zone and the default reflects the project\u0027s home instance.
`.forgejo/workflows/ci.yml` line 85
🔴 Not actioned — pre-existing pattern, acceptable for a private forge instance.
`.forgejo/workflows/ci.yml` line 121
🔴 Not actioned — pattern copied from established CI setup, acceptable for a private forge instance.