Migrate yilan from Codeberg to forge.marvin8.zone #15
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/issue-14-migrate-to-forge"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #14
Summary
Migrates yilan from Codeberg.org to forge.marvin8.zone.
Changes
Not changed
WuMing
Found 1 issue(s). See inline comments below.
@ -67,3 +67,3 @@Full URL to the raw file contents."""return f"https://codeberg.org/{owner}/{repo}/raw/branch/main/{path}"return f"https://forge.marvin8.zone/{owner}/{repo}/raw/branch/main/{path}"code [LOW]
The raw URL domain is hardcoded separately from the API base URL. If the API base URL changes, this must also be updated, leading to potential inconsistency. Consider deriving the raw URL from the configured API base URL or a shared constant.
0bab6941b03dce2f7879WuMing
Found 2 issue(s). See inline comments below.
@ -13,3 +13,3 @@if: github.event_name == 'pull_request'steps:- uses: https://codeberg.org/marvin8/wuming@main- uses: https://forge.marvin8.zone/marvin8/wuming@mainsecurity [MEDIUM]
External action referenced by branch name
@maininstead of a pinned commit SHA. The action could be silently modified, introducing malicious code. Pin to a full commit hash to ensure integrity. A08: Software and Data Integrity Failures.@ -84,3 +84,3 @@git config user.email "ci@forgejo"git config user.name "Forgejo Actions"git remote set-url origin https://x-token-auth:$FORGEJO_TOKEN@codeberg.org/$REPOSITORY.gitgit remote set-url origin https://x-token-auth:$FORGEJO_TOKEN@forge.marvin8.zone/$REPOSITORY.gitsecurity [HIGH]
Password token exposed in URL via command-line argument. This can leak the token through CI log output, process listings, or shell history. Use environment variable substitution in a way that avoids embedding the secret directly in the command line, e.g., using
git remote set-url origin https://x-token-auth:$(echo $FORGEJO_TOKEN)@...is still problematic; consider authenticating via a credential helper instead. A02: Cryptographic Failures.src/yilan/http_client.pyline 0🔴 Deferred to follow-up issue #16 — not in scope for this migration.
.forgejo/workflows/ci.ymlline 0🔴 Not actioned — established pattern in Forgejo Actions deploy-docs workflows. The token comes from
forge.token(built-in secret) and this is a self-hosted forge with minimal attack surface..forgejo/workflows/ci.ymlline 0🔴 Not actioned — established pattern. WuMing is a self-hosted action on the same forge instance. Pinning to a SHA would require manual updates on every WuMing release.